Skip to content

Simplify installation instruction when using npm #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mahalay
Copy link
Contributor

@mahalay mahalay commented Nov 16, 2017

No description provided.

@mahalay
Copy link
Contributor Author

mahalay commented Nov 16, 2017

Please hold... I'd like to add improvements to this PR.

@mahalay
Copy link
Contributor Author

mahalay commented Nov 16, 2017

I need to clarify a few things:

  1. Can encore be installed in three ways? (i.e., using yarn, npm, or composer)
  2. Or is encore installed by either npm or yarn only, then one has to run composer require encore?

The reason I asked for the latter is due to the fact that installing encore using composer doesn't create the expected node_modules/ directory. Without this directory, a newbie like me won't be able to follow the next set of instructions.

@mahalay
Copy link
Contributor Author

mahalay commented Nov 16, 2017

This should be ready for review. I figured that the composer package encore is just there to initialize encore for your Symfony project. But the actual installation is through Yarn or Npm.

@weaverryan
Copy link
Member

Closing in favor of the identical #8674, because I noticed it first ;).

@mahalay we only need the one PR, we'll merge into all branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants